Fix session cleanup on error paths

Signed-off-by: Sean Du <do4suki@gmail.com>

internal/handler/achievement/pagingaccomplishedlist.go

@@ -16,7 +16,7 @@ const pagingAccomplishedPageSize = 10
 
 func pagingAccomplishedList(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := achievementschema.PagingAccomplishedListReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/album/seriesall.go

@@ -12,7 +12,7 @@ import (
 
 func seriesAll(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	var albumID []int
 	err := ss.MainEng.Table("album_series_m").Select("album_series_id").Find(&albumID)

internal/handler/announce/checkstate.go

@@ -13,7 +13,7 @@ import (
 
 func checkState(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(announceschema.CheckStateDataResp{
 		ResponseData: announceschema.CheckStateData{

internal/handler/api/api.go

@@ -41,7 +41,7 @@ import (
 
 func api(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	apiReq := []apischema.ApiReq{}
 	err := honokautils.ParseRequestData(ctx, &apiReq)

internal/handler/award/set.go

@@ -14,7 +14,7 @@ import (
 
 func set(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	reqData := gjson.Parse(ctx.MustGet("request_data").(string))
 	pref := usermodel.UserPref{

internal/handler/background/set.go

@@ -14,7 +14,7 @@ import (
 
 func set(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	reqData := gjson.Parse(ctx.MustGet("request_data").(string))
 	pref := usermodel.UserPref{

internal/handler/banner/list.go

@@ -18,7 +18,7 @@ type bannerResp struct {
 
 func list(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	data, err := apibanner.BannerApi("bannerList")
 	if ss.CheckErr(err) {

internal/handler/download/additional.go

@@ -15,7 +15,7 @@ import (
 
 func additional(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	downloadReq := downloadschema.AdditionalReq{}
 	err := honokautils.ParseRequestData(ctx, &downloadReq)

internal/handler/download/batch.go

@@ -16,7 +16,7 @@ import (
 
 func batch(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	downloadReq := downloadschema.BatchReq{}
 	err := honokautils.ParseRequestData(ctx, &downloadReq)

internal/handler/download/event.go

@@ -12,7 +12,7 @@ import (
 
 func event(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(downloadschema.EventResp{
 		ResponseData: []any{},

internal/handler/download/geturl.go

@@ -16,7 +16,7 @@ import (
 
 func getUrl(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	downloadReq := downloadschema.UrlReq{}
 	err := honokautils.ParseRequestData(ctx, &downloadReq)

internal/handler/download/update.go

@@ -19,7 +19,7 @@ const overrideServerConfigFileName = "99_0_115.zip"
 
 func update(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	downloadReq := downloadschema.UpdateReq{}
 	err := honokautils.ParseRequestData(ctx, &downloadReq)

internal/handler/event/list.go

@@ -13,7 +13,7 @@ import (
 
 func list(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	targets := []eventschema.TargetList{}
 	for i := range 6 {

internal/handler/eventscenario/startup.go

@@ -13,7 +13,7 @@ import (
 
 func startup(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	startReq := eventscenarioschema.StartUpReq{}
 	err := honokautils.ParseRequestData(ctx, &startReq)

internal/handler/friend/expel.go

@@ -14,7 +14,7 @@ import (
 
 func expel(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := friendschema.UserIDReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/friend/list.go

@@ -33,7 +33,7 @@ type friendListRow struct {
 
 func list(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	listReq := friendschema.ListReq{}
 	err := honokautils.ParseRequestData(ctx, &listReq)

internal/handler/friend/request.go

@@ -15,7 +15,7 @@ import (
 
 func request(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := friendschema.UserIDReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/friend/requestcancel.go

@@ -14,7 +14,7 @@ import (
 
 func requestCancel(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := friendschema.UserIDReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/friend/response.go

@@ -15,7 +15,7 @@ import (
 
 func response(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := friendschema.ResponseReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/friend/search.go

@@ -30,7 +30,7 @@ type friendSearchRow struct {
 
 func search(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := friendschema.SearchReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/gdpr/get.go

@@ -13,7 +13,7 @@ import (
 
 func get(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(gdprschema.GetResp{
 		ResponseData: gdprschema.GetData{

internal/handler/ghome/account/active.go

@@ -10,7 +10,7 @@ import (
 
 func active(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(ghomeschema.ActiveResp{
 		Code: 0,

internal/handler/ghome/account/initialize.go

@@ -14,7 +14,7 @@ import (
 
 func initialize(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	initData := ghomeschema.InitializeData{
 		BrandLogo:                 "http://gskd.sdo.com/ghome/ztc/logo/og/logo_xhdpi.png",

internal/handler/ghome/account/login.go

@@ -34,7 +34,7 @@ const (
 
 func login(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	data, err := ctx.GetRawData()
 	if ss.CheckErr(err) {

internal/handler/ghome/account/loginauto.go

@@ -16,7 +16,7 @@ import (
 
 func loginAuto(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	data, err := ctx.GetRawData()
 	if ss.CheckErr(err) {

internal/handler/ghome/account/reportrole.go

@@ -12,7 +12,7 @@ import (
 
 func reportRole(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	randKey, err := ss.Get3DESRandKey()
 	if ss.CheckErr(err) {

internal/handler/ghome/basic/getcode.go

@@ -11,7 +11,7 @@ import (
 
 func getCode(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	codeArray := `{"codeArray":[{"btntext":"好的","code":"-10264022","msg_from":2,"text":"","title":"短信验证码被阻止","type":1},{"btntext":"","code":"-10869623","msg_from":2,"text":"","title":"网络连接失败，无法一键登录","type":2},{"btntext":"","code":"10298300","msg_from":2,"text":"","title":"","type":3},{"btntext":"","code":"10298311","msg_from":2,"text":"","title":"","type":3},{"btntext":"","code":"10298312","msg_from":2,"text":"","title":"","type":3},{"btntext":"","code":"10298313","msg_from":2,"text":"","title":"","type":1},{"btntext":"","code":"10298321","msg_from":2,"text":"","title":"","type":3},{"btntext":"","code":"10298322","msg_from":2,"text":"","title":"","type":3}],"codeVersion":"1.0.5"}`
 	getCodeData := map[string]any{}

internal/handler/ghome/basic/getproductlist.go

@@ -10,7 +10,7 @@ import (
 
 func getProductList(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	getProductListData := ghomeschema.GetProductListData{
 		Message: []string{},

internal/handler/ghome/basic/handshake.go

@@ -18,7 +18,7 @@ import (
 
 func handshake(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	data, err := ctx.GetRawData()
 	if ss.CheckErr(err) {

internal/handler/ghome/basic/loginarea.go

@@ -10,7 +10,7 @@ import (
 
 func loginArea(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(ghomeschema.LoginAreaResp{
 		Code: 0,

internal/handler/ghome/basic/publickey.go

@@ -14,7 +14,7 @@ import (
 
 func publicKey(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	publicKeyCode := 0
 	publicKeyMsg := "ok"

internal/handler/ghome/guest/status.go

@@ -10,7 +10,7 @@ import (
 
 func status(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(ghomeschema.GuestStatusResp{
 		Code: 0,

internal/handler/ghome/misc/agreement.go

@@ -10,7 +10,7 @@ import (
 
 func agreement(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(ghomeschema.AgreementResp{
 		ReturnCode:    0,

internal/handler/ghome/misc/integration.go

@@ -10,7 +10,7 @@ import (
 
 func appReport(ctx *gin.Context) {
 	ss := session.Attach(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(ghomeschema.AppReportResp{
 		Code: 0,

internal/handler/greet/delete.go

@@ -16,7 +16,7 @@ import (
 
 func deleteMail(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := greetschema.DeleteReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/greet/user.go

@@ -18,7 +18,7 @@ import (
 
 func user(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := greetschema.UserReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/lbonus/execute.go

@@ -13,7 +13,7 @@ import (
 
 func execute(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	weeks := map[string]int{
 		"Monday":    1,

internal/handler/live/continue.go

@@ -13,7 +13,7 @@ import (
 
 func continuee(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(BuildContinueResp(ss))
 }

internal/handler/live/partylist.go

@@ -14,7 +14,7 @@ import (
 
 func partyList(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 	partyListData, err := BuildPartyListData(ss)
 	if ss.CheckErr(err) {
 		return

internal/handler/live/play.go

@@ -17,7 +17,7 @@ import (
 
 func play(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	playReq := liveschema.PlayReq{}
 	err := honokautils.ParseRequestData(ctx, &playReq)

internal/handler/live/precisescore.go

@@ -18,7 +18,7 @@ import (
 
 func preciseScore(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	playScoreReq := liveschema.PlayScoreReq{}
 	err := honokautils.ParseRequestData(ctx, &playScoreReq)

internal/handler/login/authkey.go

@@ -18,7 +18,7 @@ import (
 
 func authKey(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	reqData := gjson.Parse(ctx.MustGet("request_data").(string))
 	dummyToken, err := base64.StdEncoding.DecodeString(reqData.Get("dummy_token").String())

internal/handler/login/login.go

@@ -19,7 +19,7 @@ import (
 
 func login(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	has, authKeyData, err := ss.GetAuthKey(ctx.MustGet("token").(string))
 	if ss.CheckErr(err) {

internal/handler/multiunit/scenariostartup.go

@@ -14,7 +14,7 @@ import (
 
 func scenarioStartup(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	startReq := multiunitschema.ScenarioStartUpReq{}
 	err := honokautils.ParseRequestData(ctx, &startReq)

internal/handler/museum/info.go

@@ -13,7 +13,7 @@ import (
 
 func info(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	var contents []struct {
 		MuseumContentsId int `xorm:"museum_contents_id"`

internal/handler/notice/friendgreeting.go

@@ -15,7 +15,7 @@ import (
 
 func friendGreeting(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := noticeschema.GreetingNoticeReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/notice/friendvariety.go

@@ -13,7 +13,7 @@ import (
 
 func friendVariety(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(noticeschema.FriendVarietyResp{
 		ResponseData: noticeschema.FriendVarietyData{

internal/handler/notice/usergreetinghistory.go

@@ -15,7 +15,7 @@ import (
 
 func userGreetingHistory(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := noticeschema.GreetingNoticeReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/payment/productlist.go

@@ -14,7 +14,7 @@ import (
 
 func productList(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	prodResp := paymentschema.ProductListResp{
 		ResponseData: paymentschema.ProductListData{

internal/handler/personalnotice/get.go

@@ -13,7 +13,7 @@ import (
 
 func get(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	noticeResp := personalnoticeschema.GetResp{
 		ResponseData: personalnoticeschema.GetData{

internal/handler/profile/register.go

@@ -14,7 +14,7 @@ import (
 
 func register(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := gjson.Parse(ctx.PostForm("request_data"))
 	pref := usermodel.UserPref{

internal/handler/ranking/live.go

@@ -28,7 +28,7 @@ type liveRankingRow struct {
 
 func live(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := rankingschema.LiveReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/reward/history.go

@@ -12,7 +12,7 @@ import (
 
 func history(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(rewardschema.HistoryResp{
 		ResponseData: rewardschema.HistoryData{

internal/handler/reward/list.go

@@ -12,7 +12,7 @@ import (
 
 func list(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(rewardschema.ListResp{
 		ResponseData: rewardschema.ListData{

internal/handler/reward/sellunit.go

@@ -13,7 +13,7 @@ import (
 
 func sellUnit(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(rewardschema.SellUnitResp{
 		ResponseData: commonschema.ErrorData{

internal/handler/rlive/continue.go

@@ -14,7 +14,7 @@ import (
 
 func continuee(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := rliveschema.TokenReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/rlive/lot.go

@@ -31,7 +31,7 @@ type randomLiveCandidateRow struct {
 
 func lot(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := rliveschema.LotReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/rlive/play.go

@@ -14,7 +14,7 @@ import (
 
 func play(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := rliveschema.PlayReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/scenario/startup.go

@@ -14,7 +14,7 @@ import (
 
 func startup(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	startReq := scenarioschema.StartUpReq{}
 	err := json.Unmarshal([]byte(ctx.PostForm("request_data")), &startReq)

internal/handler/secretbox/multi.go

@@ -13,7 +13,7 @@ import (
 
 func multi(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	multiReq := secretboxschema.MultiReq{}
 	err := honokautils.ParseRequestData(ctx, &multiReq)

internal/handler/secretbox/pon.go

@@ -18,7 +18,7 @@ import (
 
 func pon(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ponReq := secretboxschema.PonReq{}
 	err := honokautils.ParseRequestData(ctx, &ponReq)

internal/handler/secretbox/showdetail.go

@@ -14,7 +14,7 @@ import (
 
 func showDetail(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	showDetailReq := secretboxschema.ShowDetailReq{}
 	err := honokautils.ParseRequestData(ctx, &showDetailReq)

internal/handler/subscenario/startup.go

@@ -14,7 +14,7 @@ import (
 
 func startup(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	startReq := subscenarioschema.StartUpReq{}
 	err := honokautils.ParseRequestData(ctx, &startReq)

internal/handler/tos/check.go

@@ -13,7 +13,7 @@ import (
 
 func check(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(tosschema.CheckResp{
 		ResponseData: tosschema.CheckData{

internal/handler/unit/deck.go

@@ -17,7 +17,7 @@ import (
 
 func deck(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	deckReq := unitschema.DeckReq{}
 	err := honokautils.ParseRequestData(ctx, &deckReq)

internal/handler/unit/deckname.go

@@ -14,7 +14,7 @@ import (
 
 func deckName(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	deckReq := unitschema.DeckNameReq{}
 	err := honokautils.ParseRequestData(ctx, &deckReq)

internal/handler/unit/favorite.go

@@ -14,7 +14,7 @@ import (
 
 func favorite(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	var req unitschema.FavoriteReq
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/unit/favoriteaccessory.go

@@ -18,7 +18,7 @@ type SetResp struct {
 
 func favoriteAccessory(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	fmt.Println(ctx.MustGet("request_data").(string))
 

internal/handler/unit/removableskillequipment.go

@@ -13,7 +13,7 @@ import (
 
 func removableSkillEquipment(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := unitschema.RemovableSkillEquipmentReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/unit/sale.go

@@ -15,7 +15,7 @@ import (
 
 func sale(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := unitschema.SaleReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/unit/setdisplayrank.go

@@ -14,7 +14,7 @@ import (
 
 func setDisplayRank(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	var req unitschema.SetDisplayRankReq
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/unit/wearaccessory.go

@@ -15,7 +15,7 @@ import (
 
 func wearAccessory(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := unitschema.WearAccessoryReq{}
 	err := honokautils.ParseRequestData(ctx, &req)

internal/handler/user/changename.go

@@ -15,7 +15,7 @@ import (
 
 func changeName(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := gjson.Parse(ctx.MustGet("request_data").(string))
 	var oldName string

internal/handler/user/changenavi.go

@@ -14,7 +14,7 @@ import (
 
 func changeNavi(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	req := gjson.Parse(ctx.MustGet("request_data").(string))
 	pref := usermodel.UserPref{

internal/handler/user/setnotificationtoken.go

@@ -12,7 +12,7 @@ import (
 
 func setNotificationToken(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	ss.Respond(userschema.SetNotificationTokenResp{
 		ResponseData: []any{},

internal/handler/user/userinfo.go

@@ -13,7 +13,7 @@ import (
 
 func userInfo(ctx *gin.Context) {
 	ss := session.Get(ctx)
-	defer ss.Finalize()
+	defer ss.FinalizeOrRollback()
 
 	userResp := userschema.UserInfoResp{
 		ResponseData: userschema.UserInfoData{

internal/middleware/common.go

@@ -29,10 +29,15 @@ func Common(ctx *gin.Context) {
 
 	ss := session.Attach(ctx)
 	ctx.Set("session", ss)
+	defer ss.FinalizeOrRollback()
 
-	if ctx.Request.URL.Path != "/login/authkey" && ctx.Request.URL.Path != "/login/login" {
+	if ctx.IsAborted() {
+		return
+	}
+
+	if !honokautils.IsMainLoginEndpoint(ctx.Request.URL.Path) {
 		if ss.UserPref.ForceRelogin {
-			honokautils.AbortMaintenanceJSON(ctx, http.StatusNotFound, honokautils.NewNotFoundContent(ctx.Request.URL.String()))
+			ss.AbortWithStatus(http.StatusNotFound, honokautils.NewNotFoundContent(ctx.Request.URL.Path))
 			return
 		}
 	}
@@ -40,7 +45,7 @@ func Common(ctx *gin.Context) {
 	authorize := ctx.GetHeader("Authorize")
 	params, err := url.ParseQuery(authorize)
 	if err != nil {
-		honokautils.AbortMaintenanceJSON(ctx, http.StatusNotFound, honokautils.NewNotFoundContent(ctx.Request.URL.String()))
+		ss.AbortWithStatus(http.StatusNotFound, honokautils.NewNotFoundContent(ctx.Request.URL.Path))
 		return
 	}
 

internal/middleware/recovery.go

@@ -21,18 +21,18 @@ func Recovery() gin.HandlerFunc {
 			stack := debug.Stack()
 			log.Printf("panic serving %s %s: %v\n%s", ctx.Request.Method, ctx.Request.URL.String(), recovered, stack)
 
+			if value, ok := ctx.Get("session"); ok {
+				if ss, ok := value.(*session.Session); ok {
+					ss.Rollback()
+				}
+			}
+
 			if !honokautils.IsMainPHPRequest(ctx.Request.URL.Path) {
 				ctx.AbortWithStatus(http.StatusInternalServerError)
 				return
 			}
 
-			content := honokautils.NewPanicContent(recovered, stack)
+			honokautils.AbortMaintenanceJSON(ctx, http.StatusInternalServerError, honokautils.NewPanicContent())
-			if value, ok := ctx.Get("session"); ok {
-				value.(*session.Session).AbortWithStatus(http.StatusInternalServerError, content)
-				return
-			}
-
-			honokautils.AbortMaintenanceJSON(ctx, http.StatusInternalServerError, content)
 		}()
 
 		ctx.Next()

internal/router/router.go

@@ -116,7 +116,7 @@ func SifRouter(r *gin.Engine) {
 			return
 		}
 
-		honokautils.AbortMaintenanceJSON(ctx, http.StatusNotFound, honokautils.NewNotFoundContent(ctx.Request.URL.String()))
+		honokautils.AbortMaintenanceJSON(ctx, http.StatusNotFound, honokautils.NewNotFoundContent(ctx.Request.URL.Path))
 	}
 	r.NoRoute(notFoundHandler)
 	r.NoMethod(notFoundHandler)

internal/session/session.go

@@ -90,7 +90,7 @@ func (ss *Session) Finalize() {
 	if err := ss.UserEng.Commit(); err != nil {
 		log.Println(err.Error())
 		ss.closeAllSessions(false)
-		ss.respondError(http.StatusInternalServerError, honokautils.NewInternalErrorContent(err))
+		ss.respondError(http.StatusInternalServerError, honokautils.NewInternalErrorContent())
 		return
 	}
 
@@ -106,7 +106,7 @@ func (ss *Session) Abort(err error) {
 
 	msg := ss.formatAbortMessage(err)
 	log.Println(msg)
-	ss.abortWithContent(http.StatusInternalServerError, honokautils.NewErrorContent("SessionAbort", msg))
+	ss.abortWithContent(http.StatusInternalServerError, honokautils.NewInternalErrorContent())
 }
 
 func (ss *Session) AbortWithStatus(status int, content any) {
@@ -116,6 +116,25 @@ func (ss *Session) AbortWithStatus(status int, content any) {
 	ss.abortWithContent(status, content)
 }
 
+// FinalizeOrRollback commits successful requests and rolls back before a panic reaches recovery.
+func (ss *Session) FinalizeOrRollback() {
+	defer func() {
+		if recovered := recover(); recovered != nil {
+			ss.Rollback()
+			panic(recovered)
+		}
+	}()
+	ss.Finalize()
+}
+
+func (ss *Session) Rollback() {
+	if ss.done {
+		return
+	}
+	ss.done = true
+	ss.closeAllSessions(true)
+}
+
 func (ss *Session) formatAbortMessage(err error) string {
 	skip := 2
 	if pc, _, _, ok := runtime.Caller(2); ok {

internal/utils/error.go

@@ -4,7 +4,6 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
-	"reflect"
 	"strconv"
 	"strings"
 
@@ -48,16 +47,19 @@ func IsUnimplementedError(err error) bool {
 const maintenanceHeader = "Maintenance"
 
 type ErrorContent struct {
-	Detail    string   `json:"detail,omitempty"`
+	Detail    string `json:"detail,omitempty"`
-	Exception string   `json:"exception,omitempty"`
+	Exception string `json:"exception,omitempty"`
-	Message   string   `json:"message,omitempty"`
+	Message   string `json:"message,omitempty"`
-	Traceback []string `json:"traceback,omitempty"`
 }
 
 func IsMainPHPRequest(path string) bool {
 	return path == "/main.php" || strings.HasPrefix(path, "/main.php/")
 }
 
+func IsMainLoginEndpoint(path string) bool {
+	return path == "/main.php/login/authkey" || path == "/main.php/login/login"
+}
+
 func WriteMaintenanceJSON(setHeader func(string, string), writeJSON func(int, any), status int, content any) {
 	setHeader("Content-Type", "application/json; charset=utf-8")
 	setHeader("status_code", strconv.Itoa(status))
@@ -80,46 +82,13 @@ func NewNotFoundContent(path string) ErrorContent {
 	return NewDetailContent(fmt.Sprintf("Endpoint not found: %s", path))
 }
 
-func NewInternalErrorContent(err error) ErrorContent {
+func NewInternalErrorContent() ErrorContent {
 	return ErrorContent{
-		Exception: exceptionName(err),
+		Exception: "InternalServerError",
-		Message:   err.Error(),
+		Message:   http.StatusText(http.StatusInternalServerError),
 	}
 }
 
-func NewErrorContent(exception, message string) ErrorContent {
+func NewPanicContent() ErrorContent {
-	return ErrorContent{
+	return NewInternalErrorContent()
-		Exception: exception,
-		Message:   message,
-	}
-}
-
-func NewPanicContent(recovered any, stack []byte) ErrorContent {
-	return ErrorContent{
-		Exception: "panic",
-		Message:   fmt.Sprint(recovered),
-		Traceback: splitLines(stack),
-	}
-}
-
-func exceptionName(err error) string {
-	if err == nil {
-		return http.StatusText(http.StatusInternalServerError)
-	}
-
-	typ := reflect.TypeOf(err)
-	if typ.Kind() == reflect.Pointer {
-		typ = typ.Elem()
-	}
-	if name := typ.Name(); name != "" {
-		return name
-	}
-	return typ.String()
-}
-
-func splitLines(stack []byte) []string {
-	if len(stack) == 0 {
-		return nil
-	}
-	return strings.Split(strings.TrimSpace(string(stack)), "\n")
 }

internal/utils/error_test.go

@@ -0,0 +1,39 @@
+package honokautils
+
+import (
+	"net/http"
+	"testing"
+)
+
+func TestInternalErrorContentIsSanitized(t *testing.T) {
+	content := NewInternalErrorContent()
+
+	if content.Exception != "InternalServerError" {
+		t.Fatalf("unexpected exception: %q", content.Exception)
+	}
+	if content.Message != http.StatusText(http.StatusInternalServerError) {
+		t.Fatalf("unexpected message: %q", content.Message)
+	}
+}
+
+func TestPanicContentIsSanitized(t *testing.T) {
+	content := NewPanicContent()
+
+	if content != NewInternalErrorContent() {
+		t.Fatalf("panic content exposes a distinct internal detail: %#v", content)
+	}
+}
+
+func TestIsMainLoginEndpoint(t *testing.T) {
+	for _, path := range []string{"/main.php/login/authkey", "/main.php/login/login"} {
+		if !IsMainLoginEndpoint(path) {
+			t.Fatalf("expected %q to be a main.php login endpoint", path)
+		}
+	}
+
+	for _, path := range []string{"/login/authkey", "/main.php/user/userInfo"} {
+		if IsMainLoginEndpoint(path) {
+			t.Fatalf("expected %q not to be a main.php login endpoint", path)
+		}
+	}
+}